search

harvard-lil / perma-extension

A browser extension for Perma.cc
MIT License
3 stars 1 forks source link

Dark theme #27

Closed matteocargnelutti closed 2 years ago

matteocargnelutti commented 2 years ago

@shljessie As discussed: First try 😃 . The color scheme changes based on OS-level preferences. Let me know what you think!

https://user-images.githubusercontent.com/625889/181026745-f274419c-1b54-4481-a633-a20990461855.mov

shljessie commented 2 years ago

@matteocargnelutti I think the dark mode color scheme looks great!

I have two questions in this section!

Screen Shot 2022-07-26 at 10 24 05 AM
  1. Why did the icon for the archiving change from the lock to this arrow (with files?)
  2. Wondering if we should do an accessibility check for the slight color change in the making the link public button? I think the contrast in the colors could be a little low. I would be happy to do this and suggest some colors! https://coolors.co/contrast-checker/112a46-acc8e5
matteocargnelutti commented 2 years ago

@shljessie Thank you very much for having a look 😄 , much appreciated.

Why did the icon for the archiving change from the lock to this arrow (with files?)

(Missing context discussed on Slack)

Wondering if we should do an accessibility check for the slight color change in the making the link public button? I think the contrast in the colors could be a little low. I would be happy to do this and suggest some colors! https://coolors.co/contrast-checker/112a46-acc8e5

That's always a good idea 😄 . I did check contrast ratios as I edited the colors for the dark theme, but suggestions are more than welcome!

For the "white on blue" buttons, I get a score of 4.59 in its default state, 4.77 on :hover. It probably can be improved!

Screen Shot 2022-07-26 at 10 35 30 AM Screen Shot 2022-07-26 at 10 36 18 AM

You'll find the color schemes I use here:

Thanks again,

shljessie commented 2 years ago

Cool! I was talking more about the button background color change from a lighter blue to a darker blue when clicked! But if the function for the button is now a copy link instead of an archive/public, I think the current color change from a lighter blue to a darker blue is good enough to let the user know it has been clicked!

matteocargnelutti commented 2 years ago

@shljessie I see, cool! Thanks again for having a look 👍 !