search

harvard-lil / perma

Indelible links
420 stars 71 forks source link

Annotate orgs and registrars earlier #3279

Closed bensteinberg closed 1 year ago

bensteinberg commented 1 year ago

Fixes #3278

The diff looks a little funny, but for both orgs and registrars, this PR just moves annotation earlier, so that last_active is present when sorting.

bensteinberg commented 1 year ago

Also fixes #3280 (just demonstrating the same error with registrars)

codecov[bot] commented 1 year ago

Codecov Report

Merging #3279 (ecaa8cc) into develop (d28250e) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3279      +/-   ##
===========================================
+ Coverage    74.34%   74.39%   +0.04%     
===========================================
  Files           55       55              
  Lines         6564     6564              
===========================================
+ Hits          4880     4883       +3     
+ Misses        1684     1681       -3
Impacted Files Coverage Δ
perma_web/perma/views/user_management.py 95.17% <100.00%> (ø)
perma_web/api/serializers.py 94.66% <0.00%> (+1.45%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.