harvard-lil / perma

Indelible links
420 stars 71 forks source link

Create extensions only in docker envs. #3307

Closed rebeccacremona closed 1 year ago

rebeccacremona commented 1 year ago

I will write all of this up in a Github issue shortly, but: we decided that the strategy for conditionally installing extensions introduced in https://github.com/harvard-lil/perma/commit/9ea178b530eac7a523583d7736874a176c6af2f8 was giving us too much trouble. After considering a number of other approaches, we decided to have the migration only be run in our Docker envs instead.

I've tested both branches of the conditional locally.

See https://github.com/harvard-lil/perma/issues/3308 for more discussion.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3307 (736451b) into develop (b2d9e50) will decrease coverage by 0.11%. The diff coverage is n/a.

:exclamation: Current head 736451b differs from pull request most recent head 3ff984f. Consider uploading reports for the commit 3ff984f to get more accurate results

@@             Coverage Diff             @@
##           develop    #3307      +/-   ##
===========================================
- Coverage    73.64%   73.54%   -0.11%     
===========================================
  Files           55       55              
  Lines         6641     6641              
===========================================
- Hits          4891     4884       -7     
- Misses        1750     1757       +7     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.