search

harvard-lil / perma

Indelible links
420 stars 71 forks source link

Upload files to and delete files from "daily" digest IA items, Part XVII #3312

Closed rebeccacremona closed 1 year ago

rebeccacremona commented 1 year ago

The queuing strategy enabled in Part XVI looks for the earliest incomplete date, and then steps up, one day at a time, from there, until it has scheduled the desired number of tasks. It doesn't check to see whether a day is already known to have been finished, before checking for upload-eligible links... which is fine, but a little inelegant: it results in unnecessary log lines and an unnecessary call to the DB.

This PR adds a quick check.

Thanks to @bensteinberg for noticing the infelicity.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3312 (f40c0bb) into develop (24ef86d) will decrease coverage by 0.04%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #3312      +/-   ##
===========================================
- Coverage    73.63%   73.60%   -0.04%     
===========================================
  Files           55       55              
  Lines         6642     6645       +3     
===========================================
  Hits          4891     4891              
- Misses        1751     1754       +3
Impacted Files Coverage Δ
perma_web/perma/celery_tasks.py 53.29% <0.00%> (-0.14%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.