search

harvard-lil / perma

Indelible links
420 stars 71 forks source link

Add missing default setting #3372

Closed rebeccacremona closed 1 year ago

rebeccacremona commented 1 year ago

By custom, we include all custom-defined settings in settings_common.py and then override their values as necessary in settings_dev.py, settings_prod.py, and settings_testing.py.

I forgot to add INTERNET_ARCHIVE_UPLOAD_MAX_TIMEOUTS, which recently caused https://github.com/harvard-lil/perma/issues/3367.

Ben's fix in https://github.com/harvard-lil/perma/pull/3368 is of course perfectly fine, but for consistency with other similar retry stanzas, this PR adds a default setting of None and reverts the code to its original state.

codecov[bot] commented 1 year ago

Codecov Report

Merging #3372 (cc3da52) into develop (7f0789f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3372   +/-   ##
========================================
  Coverage    69.75%   69.75%           
========================================
  Files           53       53           
  Lines         7098     7098           
========================================
  Hits          4951     4951           
  Misses        2147     2147
Impacted Files Coverage Δ
perma_web/perma/celery_tasks.py 53.12% <ø> (ø)