search

harvard-lil / perma

Indelible links
411 stars 70 forks source link

Don't assume pageInfo is present. #3421

Closed rebeccacremona closed 8 months ago

rebeccacremona commented 8 months ago

Similar to https://github.com/harvard-lil/perma/pull/3419, we have observed than on occasion, pageInfo is not present as expected in the metadata.

Let's not make that fatal, even as we debug.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (ac1454d) 68.78% compared to head (8d4c520) 68.75%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3421 +/- ## =========================================== - Coverage 68.78% 68.75% -0.03% =========================================== Files 53 53 Lines 7308 7311 +3 =========================================== Hits 5027 5027 - Misses 2281 2284 +3 ``` | [Files](https://app.codecov.io/gh/harvard-lil/perma/pull/3421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=harvard-lil) | Coverage Δ | | |---|---|---| | [perma\_web/perma/celery\_tasks.py](https://app.codecov.io/gh/harvard-lil/perma/pull/3421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=harvard-lil#diff-cGVybWFfd2ViL3Blcm1hL2NlbGVyeV90YXNrcy5weQ==) | `47.20% <0.00%> (-0.11%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.