search

harvard-lil / perma

Indelible links
411 stars 70 forks source link

Remove Perma's capture code (that was replaced by Scoop) #3434

Closed rebeccacremona closed 8 months ago

rebeccacremona commented 8 months ago

See ENG-403

We are now comfortable removing Perma's own capture code: capture via Scoop seems to be going great!

I decided to keep the CAPTURE_ENGINE settings and leave run_next_capture() as is for now; let's discuss whether it is more proper/cleaner to remove it.

...

So long, code! You served us well!

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e659190) 64.40% compared to head (896bc1c) 69.84%. Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3434 +/- ## =========================================== + Coverage 64.40% 69.84% +5.44% =========================================== Files 53 52 -1 Lines 7340 6620 -720 =========================================== - Hits 4727 4624 -103 + Misses 2613 1996 -617 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rebeccacremona commented 8 months ago

Do you think we'll need to keep CAPTURE_USER_AGENT updated? Maybe, but maybe not often.

I'm of mixed minds... I am unsure about the wisdom of continuing to have Perma validate the URL at all... it could be, it would be better to delegate that responsibility to the Scoop API. But we haven't talked about that yet, and whether that would be carving at the joints, or, rather, would be overloading that API.