search

harvard-lil / perma

Indelible links
411 stars 70 forks source link

Resolve python warnings during tests #3446

Closed rebeccacremona closed 7 months ago

rebeccacremona commented 7 months ago

I noticed that pytest was reporting a lot of warnings:

image

It turns out that fixing them was no big deal: just a few tweaks and package upgrades.

There's only one left unresolved, a deprecation warning about a line in warctools, which we are still using to produce upload-your-own warcs:

image

That library is not under active development; if it becomes a problem before we switch to WACZ, we can figure out what we want to do. But in the meantime, I'm leaving it.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f84ad8d) 70.29% compared to head (c5b76cf) 70.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3446 +/- ## ======================================== Coverage 70.29% 70.30% ======================================== Files 52 52 Lines 6727 6729 +2 ======================================== + Hits 4729 4731 +2 Misses 1998 1998 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.