Closed rebeccacremona closed 7 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
c5b76cf
) 70.30% compared to head (e2cab71
) 70.65%. Report is 9 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
perma_web/tasks/dev.py | 0.00% | 5 Missing :warning: |
perma_web/perma/models.py | 50.00% | 1 Missing :warning: |
perma_web/perma/views/service.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks! I think you don't have to install libpango-1.0-0
and libcairo2
: I just had to do that for the functional tests, which use playwright and chromium. I don't think you have to install any of the packages in that stanza, right?
Ah whoops right, thanks.
The carousel of registrar logos and list of "partners" was recently removed from Perma's landing and about pages.
This PR follows up and removes the remaining code and dependencies that only supported that feature.
That includes legacy "thumbnail"-related code and dependencies that haven't been in use at any point during my tenure at LIL.
I was able to remove some packages from the Docker image:
We probably want to make a similar move on the stage and prod minions after deployment.
See ENG-173.