search

harvard-lil / perma

Indelible links
408 stars 72 forks source link

Add a global feature flag to toggle URL validation strategy #3459

Closed rebeccacremona closed 6 months ago

rebeccacremona commented 6 months ago

We are planning to delegate submitted URL validation to the Scoop API.

This is a no-op PR to preemptively add a global feature flag setting to let us experiment with that easily.

I sketched in what a possible implementation could look like, in a comment, to guide the development of that Scoop API route.

See ENG-502.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (659984f) 71.12% compared to head (ec4251f) 71.12%.

Files Patch % Lines
perma_web/api/serializers.py 77.27% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3459 +/- ## =========================================== - Coverage 71.12% 71.12% -0.01% =========================================== Files 48 48 Lines 6439 6441 +2 =========================================== + Hits 4580 4581 +1 - Misses 1859 1860 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rebeccacremona commented 6 months ago

Thanks for the fixes, @kilbergr!