harvard-lil / perma

Indelible links
417 stars 71 forks source link

Send URL validation requests to Scoop API #3462

Closed rebeccacremona closed 9 months ago

rebeccacremona commented 9 months ago

See ENG-502.

This PR updates Perma's dev environment to use the latest Scoop API and, arranges so that, when VALIDATE_URL_LOCALLY is False, URLs submitted to Perma for capture are validated by the Scoop API instead of locally by the Perma app.

It toggles the flag in CI, but keeps it True for deployments by default: to be discussed. Maybe I should just change it in settings_common: so far as I am concerned we are ready to give it a try.

rebeccacremona commented 9 months ago

(The tests probably failed because this is not the right IP range to allowlist in CI)

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (edaa9ee) 71.25% compared to head (48482f3) 70.72%. Report is 6 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3462 +/- ## =========================================== - Coverage 71.25% 70.72% -0.53% =========================================== Files 48 48 Lines 6471 6494 +23 =========================================== - Hits 4611 4593 -18 - Misses 1860 1901 +41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sentry-io[bot] commented 9 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

rebeccacremona commented 9 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

* ‼️ **ScoopAPIException: 502: {}** `/api/v1/user/archives/` [View Issue](https://library-innovation-lab-harvard.sentry.io/issues/4808428104/?referrer=github-pr-bot)

Did you find this useful? React with a 👍 or 👎

Just a single instance, it's fine, Sentry, thanks though.