Closed rebeccacremona closed 9 months ago
(The tests probably failed because this is not the right IP range to allowlist in CI)
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
edaa9ee
) 71.25% compared to head (48482f3
) 70.72%. Report is 6 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was deployed and Sentry observed the following issues:
/api/v1/user/archives/
View Issue/api/v1/user/archives/
View IssueDid you find this useful? React with a 👍 or 👎
Suspect Issues
This pull request was deployed and Sentry observed the following issues:
* ‼️ **ScoopAPIException: 502: {}** `/api/v1/user/archives/` [View Issue](https://library-innovation-lab-harvard.sentry.io/issues/4808428104/?referrer=github-pr-bot)
Did you find this useful? React with a 👍 or 👎
Just a single instance, it's fine, Sentry, thanks though.
See ENG-502.
This PR updates Perma's dev environment to use the latest Scoop API and, arranges so that, when
VALIDATE_URL_LOCALLY
isFalse
, URLs submitted to Perma for capture are validated by the Scoop API instead of locally by the Perma app.It toggles the flag in CI, but keeps it
True
for deployments by default: to be discussed. Maybe I should just change it insettings_common
: so far as I am concerned we are ready to give it a try.