harvard-lil / perma

Indelible links
408 stars 72 forks source link

Contact form for sponsored users should cc registrar users too. #3472

Closed rebeccacremona closed 5 months ago

rebeccacremona commented 5 months ago

See ENG-525.

Back when, we altered the contact form so that, when it is submitted by an org user, their registrar users are cc'ed. The idea was, this would encourage registrars to support their users :-)

A few years later, we introduced "sponsored users" to the mix. Sponsored users are affiliated directly with a registrar, without an org. We did not add anything to the contact form at the time.

This PR addresses the oversight.

I added a test for a sponsored user, but I did not replicate all the existing styles of test we currently have for the contact form: these tests were some of the first tests I had ever written, and they are not particularly well-designed 🤣. There is a lot of duplicative stuff. I think this test, by itself, is good enough, pending a refactor of the test suite :-).

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (319384b) 71.18% compared to head (9cbc1f7) 71.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3472 +/- ## =========================================== + Coverage 71.18% 71.21% +0.03% =========================================== Files 48 48 Lines 6486 6494 +8 =========================================== + Hits 4617 4625 +8 Misses 1869 1869 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.