Closed rebeccacremona closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3523e14
) 71.21% compared to head (a3202e2
) 71.22%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This pull request was deployed and Sentry observed the following issues:
/api/v1/user/archives/
View IssueDid you find this useful? React with a 👍 or 👎
We recently made a change to Perma's URL validation behavior: we used to validate URLs locally, but now we send the URLs to the Scoop API for validation.
When I added the new code, I missed two important lines. We are not supposed to validate the URL, if making a Perma Link from an upload instead of from a capture.
It turns out that our tests of the upload-your-own functionality use the same URL every time... a valid one.
So, this PR does two thing:
if not uploaded_file:
, and