Closed tinykite closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.22%. Comparing base (
aafc6c0
) to head (4c41e23
). Report is 1 commits behind head on develop.:exclamation: Current head 4c41e23 differs from pull request most recent head b51bc33. Consider uploading reports for the commit b51bc33 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
No problem at all!
And thank you for this context — I've never worked on a project that included map files or other forms of production-ready build files, but I've also never worked on a project with an embedded web application within Django, and it's easy enough to commit whatever files are necessary.
What this does
This adds two components,
App.vue
andHelloWorld.vue
. It's basically a very light refactoring of what we already had into Vue-specific components: a primaryApp.vue
that we'll add all individual components to, and an additional test component with some superfluous text defined in aref
to test out that we can scope JavaScript to an individual component.This component is intentionally extremely basic for the purpose of iterative development. In the future, another PR will update this component to do something more meaningful than simply render "Hello world"
Screenshots
If Vue Dev Tools are installed, and Vue has successfully loaded, there should be a "Vue" tab in dev tools for browsers such as Vue and Arc that displays a tree view of the currently rendered components:![Screenshot 2024-03-21 at 1 13 17 PM](https://github.com/harvard-lil/perma/assets/4039311/e5ae15fe-cfba-417f-9302-aabc0f040b14)
The rendered "Hello world!" text in Perma![Screenshot 2024-03-21 at 1 13 35 PM](https://github.com/harvard-lil/perma/assets/4039311/4bab7cac-4218-4f62-9503-210eeaa4cbd2)
How to test
If the cookie shows up in dev tools but you don't see "Hello world!" on the page, you may need to do a hard refresh or open an incognito window, and verify that:
<div id="vue-app"></div>
is present on the pageOpen Questions
static
directory:dashboard.js
anddashboard.js.map
. Are these necessary to ship to production, or should we update our.gitignore
to ignore these and other static exports?