harvard-lil / perma

Indelible links
408 stars 72 forks source link

Add app and test vue components #3485

Closed tinykite closed 3 months ago

tinykite commented 3 months ago

What this does

This adds two components, App.vue and HelloWorld.vue. It's basically a very light refactoring of what we already had into Vue-specific components: a primary App.vue that we'll add all individual components to, and an additional test component with some superfluous text defined in a ref to test out that we can scope JavaScript to an individual component.

This component is intentionally extremely basic for the purpose of iterative development. In the future, another PR will update this component to do something more meaningful than simply render "Hello world"

Screenshots

If Vue Dev Tools are installed, and Vue has successfully loaded, there should be a "Vue" tab in dev tools for browsers such as Vue and Arc that displays a tree view of the currently rendered components: Screenshot 2024-03-21 at 1 13 17 PM

The rendered "Hello world!" text in Perma Screenshot 2024-03-21 at 1 13 35 PM

How to test

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.22%. Comparing base (aafc6c0) to head (4c41e23). Report is 1 commits behind head on develop.

:exclamation: Current head 4c41e23 differs from pull request most recent head b51bc33. Consider uploading reports for the commit b51bc33 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3485 +/- ## ======================================== Coverage 71.22% 71.22% ======================================== Files 48 48 Lines 6512 6512 ======================================== Hits 4638 4638 Misses 1874 1874 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tinykite commented 3 months ago

No problem at all!

And thank you for this context — I've never worked on a project that included map files or other forms of production-ready build files, but I've also never worked on a project with an embedded web application within Django, and it's easy enough to commit whatever files are necessary.