Closed matteocargnelutti closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.22%. Comparing base (
6b447bc
) to head (efa78c0
). Report is 1 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks great!!!
I tested by:
node_modules
folder, to make sure it didn't accidentally sync a cache of the old dependencies into the containerperma_node_modules
volume, for the same reasontest-node-dependencies
suffix to the web
image's tag to force a rebuild without clobbering the 105-28fef2ca2ecd1c74ba3059f0b59a4d34
imagedocker compose up
, and watching the builddocker compose exec web invoke run
, with CELERY_TASK_ALWAYS_EAGER = False
I can't think of anything else to check!!
This is awesome -- I think ship it if Ben is happy? As Becky points out we use pre-built assets in production, so the testing she did is likely to have found any problems that might exist.
Thank you all for having a look and for the helpful feedback 👋
How I tested these changes:
docker compose up -d --build
to force a rebuildIn the web container's shell:
npm run build
does generate valid (?) bundlesinvoke run
successfully runsnpm run build
npx js-wacz --help
prints js-wacz's help menuTests are passing and the app behaves normally when tested locally.