harvard-lil / perma

Indelible links
408 stars 72 forks source link

Test with Node 20, updated deps + js-wacz #3486

Closed matteocargnelutti closed 3 months ago

matteocargnelutti commented 3 months ago

How I tested these changes:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.22%. Comparing base (6b447bc) to head (efa78c0). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3486 +/- ## ======================================== Coverage 71.22% 71.22% ======================================== Files 48 48 Lines 6512 6512 ======================================== Hits 4638 4638 Misses 1874 1874 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rebeccacremona commented 3 months ago

This looks great!!!

I tested by:

I can't think of anything else to check!!

jcushman commented 3 months ago

This is awesome -- I think ship it if Ben is happy? As Becky points out we use pre-built assets in production, so the testing she did is likely to have found any problems that might exist.

matteocargnelutti commented 3 months ago

Thank you all for having a look and for the helpful feedback 👋