harvard-lil / perma

Indelible links
417 stars 71 forks source link

Add form #3489

Closed tinykite closed 5 months ago

tinykite commented 6 months ago

What this does

Duplicates a portion of the form Perma provides to create an archive of a single link, as a portion of ENG-771. Some pertinent notes:

Screenshots

Ready to handle single url archive requests Screenshot 2024-04-03 at 2 06 45 PM

Waiting for a response from the /archives endpoint Screenshot of a perma dashboard waiting for a response from an API

After the archives API returns a GUID for a link, the state of the archive process will switch to "isQueing" Screenshot of ready GUID

When a capture is in progress, the page will display the status of the overall archiving process and the progress percent of the capture job specifically Screenshot of capture in progress

A capture failure A screenshot of a capture failure

Redirecting to the archive after a successful capture Screenshot of a Perma archive

Testing notes

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.48%. Comparing base (a2fed03) to head (077d758). Report is 30 commits behind head on develop.

:exclamation: Current head 077d758 differs from pull request most recent head efd4405. Consider uploading reports for the commit efd4405 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3489 +/- ## =========================================== - Coverage 71.22% 70.48% -0.74% =========================================== Files 48 48 Lines 6512 6594 +82 =========================================== + Hits 4638 4648 +10 - Misses 1874 1946 +72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tinykite commented 5 months ago

@rebeccacremona can you take another look? Made a handful of fixes, based on feedback.

Additionally — regarding the cookie utility function — let me know if you want to revert that, that's an easy fix too!