harvard-lil / perma

Indelible links
408 stars 72 forks source link

Add button loaders #3491

Closed tinykite closed 3 months ago

tinykite commented 3 months ago

What this does

Adds two components, Spinner and ProgressBar, that can be added to submit buttons in the updated Perma dashboard. One quick additional note:

Screenshots

Disabled spinner screenshot Disabled spinner

Enabled spinner screenshot Enabled spinner

How to test

Without the context of #3489, I tested this by adding the Spinner and Progress bar by themselves to App.vue:

<script setup>
import Spinner from './Spinner.vue';
import ProgressBar from './ProgressBar.vue';
</script>

<template>
    <Spinner top="-20px" isDisabled />
    <ProgressBar progress="90%" />
</template>

Additional testing notes:

<ProgressBar :progress="someDynamicProgressState" />
<Spinner :isDisabled="false" />
tinykite commented 3 months ago

Thank you for the review!