harvard-lil / perma

Indelible links
408 stars 72 forks source link

Add link counter #3499

Closed tinykite closed 2 months ago

tinykite commented 2 months ago

What this does

Notes

Screenshots

Displaying the remaining metere links a user has available. Screenshot 2024-04-10 at 4 35 49 PM

Displaying the remaining metered links a user has available for the rest of the year, if they have an annually renewing Perma subscription. Screenshot 2024-04-10 at 4 59 43 PM

Notifying a user they have paid for unlimited perma links. Screenshot 2024-04-10 at 4 39 48 PM

Notifying a free Perma user they have been upgraded to unlimited free perma links. Screenshot 2024-04-10 at 4 38 39 PM

Notifying any individual Perma user that they have an issue with their billing details. Screenshot 2024-04-11 at 3 15 40 PM

While gathering these screenshots, I noticed that we don't always consistently use periods to end statements. Should we consistently do so? (Or remove the instances where we do use periods?)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.35%. Comparing base (41b6638) to head (c1eaead). Report is 72 commits behind head on develop.

:exclamation: Current head c1eaead differs from pull request most recent head d109992. Consider uploading reports for the commit d109992 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3499 +/- ## =========================================== + Coverage 70.33% 70.35% +0.02% =========================================== Files 48 48 Lines 6613 6611 -2 =========================================== Hits 4651 4651 + Misses 1962 1960 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tinykite commented 2 months ago

Love the question about some things ending in periods and some not. I guarantee that is by accident. What do you think looks best? Consistently using periods?

I think using periods is the most consistent. Where I've worked at the past, it was our style to always add periods to statements (regardless of if it was a complete statement) and feels the easiest to reason about. Updated this in revision 839094c

Additionally regarding the new variables — yes! I am always in favor of simplifying this if possible, I'll file this away in my brain as a possible future improvement.