Closed tinykite closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.35%. Comparing base (
41b6638
) to head (c1eaead
). Report is 72 commits behind head on develop.:exclamation: Current head c1eaead differs from pull request most recent head d109992. Consider uploading reports for the commit d109992 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Love the question about some things ending in periods and some not. I guarantee that is by accident. What do you think looks best? Consistently using periods?
I think using periods is the most consistent. Where I've worked at the past, it was our style to always add periods to statements (regardless of if it was a complete statement) and feels the easiest to reason about. Updated this in revision 839094c
Additionally regarding the new variables — yes! I am always in favor of simplifying this if possible, I'll file this away in my brain as a possible future improvement.
What this does
LinkCount
plus two new additional store properties,subscriptionStatus
anduserTypes
.Notes
subscriptionStatus
state that could be derived from the conditional logic of the tree.userTypes
to potentially easily reference these values, but right now we only needed to store whether or not someone is an individual.Screenshots
Displaying the remaining metere links a user has available.![Screenshot 2024-04-10 at 4 35 49 PM](https://github.com/harvard-lil/perma/assets/4039311/30bbd049-690d-41b9-a976-7357b255493c)
Displaying the remaining metered links a user has available for the rest of the year, if they have an annually renewing Perma subscription.![Screenshot 2024-04-10 at 4 59 43 PM](https://github.com/harvard-lil/perma/assets/4039311/cbf1f39c-8ec6-4915-8dde-486700baa2da)
Notifying a user they have paid for unlimited perma links.![Screenshot 2024-04-10 at 4 39 48 PM](https://github.com/harvard-lil/perma/assets/4039311/b6cfd60d-f5ac-4f1c-93a8-7706003ae922)
Notifying a free Perma user they have been upgraded to unlimited free perma links.![Screenshot 2024-04-10 at 4 38 39 PM](https://github.com/harvard-lil/perma/assets/4039311/60de6516-af10-4562-baf2-def53111aa68)
Notifying any individual Perma user that they have an issue with their billing details.![Screenshot 2024-04-11 at 3 15 40 PM](https://github.com/harvard-lil/perma/assets/4039311/bb7670ec-ab30-43b8-b6fd-43582106567b)
While gathering these screenshots, I noticed that we don't always consistently use periods to end statements. Should we consistently do so? (Or remove the instances where we do use periods?)