harvard-lil / perma

Indelible links
408 stars 72 forks source link

add batch_size arg, time different steps #3505

Closed teovin closed 2 months ago

teovin commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 70.27%. Comparing base (c1eaead) to head (d32d3bd). Report is 30 commits behind head on develop.

:exclamation: Current head d32d3bd differs from pull request most recent head aebd55d. Consider uploading reports for the commit aebd55d to get more accurate results

Files Patch % Lines
perma_web/perma/celery_tasks.py 0.00% 13 Missing :warning:
perma_web/tasks/dev.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3505 +/- ## =========================================== - Coverage 70.35% 70.27% -0.08% =========================================== Files 48 48 Lines 6611 6627 +16 =========================================== + Hits 4651 4657 +6 - Misses 1960 1970 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teovin commented 2 months ago

Looks great! I just have one performance-related suggestion 🙂. Really looking forward to running this experiment!!

Thank you for the great explanation and the change is pushed! :)