Closed rebeccacremona closed 4 weeks ago
Attention: Patch coverage is 5.88235%
with 16 lines
in your changes missing coverage. Please review.
Project coverage is 69.50%. Comparing base (
7d556e4
) to head (ab146f3
). Report is 63 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
perma_web/perma/models.py | 9.09% | 10 Missing :warning: |
perma_web/perma/celery_tasks.py | 0.00% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
WACZ files include, zipped inside them, a file called pages.jsonl, which helps replay software know what the "entrypoint" URLs are for a given archive.
This PR makes the pages.jsonl produced during the conversion process more closely match the pages.jsonl produced during a Scoop WACZ capture of a target URL.
Before:
After:
(We decided NOT to include the optional "id" field since it IS optional, and since it is primarily there to optimize performance when you have thousands or millions of pages... as opposed to 1-3, like us.)
See ENG-922.