search

harvard-lil / perma

Indelible links
408 stars 72 forks source link

Update urllib3 #3547

Closed bensteinberg closed 2 weeks ago

bensteinberg commented 2 weeks ago

Although this upgrade could have been to 1.26.19, 2.07 is what pip-compile did, suggesting that our dependencies that depend on it are happy with it.

https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#207-2023-10-17

See also https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html

I did not see any urllib3 deprecations when I ran the tests locally.

If the major version update seems iffy, I can redo this with 1.26.19.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.87%. Comparing base (47caa5e) to head (f2fe981). Report is 7 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3547 +/- ## =========================================== - Coverage 69.01% 68.87% -0.15% =========================================== Files 48 48 Lines 6842 6856 +14 =========================================== Hits 4722 4722 - Misses 2120 2134 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.