harvard-lil / perma

Indelible links
417 stars 71 forks source link

Enable retrieving WACZ via DEFAULT_TO_WACZ setting #3548

Closed cmsetzer closed 3 months ago

cmsetzer commented 3 months ago

This enables WACZ retrieval when the new DEFAULT_TO_WACZ setting is enabled. Highlights:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.76%. Comparing base (47caa5e) to head (8bd269e). Report is 10 commits behind head on develop.

Files Patch % Lines
perma_web/perma/celery_tasks.py 53.84% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3548 +/- ## =========================================== - Coverage 69.01% 68.76% -0.25% =========================================== Files 48 48 Lines 6842 6871 +29 =========================================== + Hits 4722 4725 +3 - Misses 2120 2146 +26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cmsetzer commented 3 months ago

Agreed about the over-broad setting name. I just pushed up 8bd269e which does the following:

Let me know if that looks good...thanks!

rebeccacremona commented 3 months ago

Agreed about the over-broad setting name. I just pushed up 8bd269e which does the following:

* Renames `DEFAULT_TO_WACZ` to `WACZ_SAVING_ENABLED`

* Adds the equivalent flag `WARC_SAVING_ENABLED` (currently set to true), which will allow us to toggle WARC storage

Let me know if that looks good...thanks!

Perfect, I think these are great. Thanks!

sentry-io[bot] commented 3 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎