Closed cmsetzer closed 3 months ago
Attention: Patch coverage is 55.55556%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 68.76%. Comparing base (
47caa5e
) to head (8bd269e
). Report is 10 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
perma_web/perma/celery_tasks.py | 53.84% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Agreed about the over-broad setting name. I just pushed up 8bd269e which does the following:
DEFAULT_TO_WACZ
to WACZ_SAVING_ENABLED
WARC_SAVING_ENABLED
(currently set to true), which will allow us to toggle WARC storageLet me know if that looks good...thanks!
Agreed about the over-broad setting name. I just pushed up 8bd269e which does the following:
* Renames `DEFAULT_TO_WACZ` to `WACZ_SAVING_ENABLED` * Adds the equivalent flag `WARC_SAVING_ENABLED` (currently set to true), which will allow us to toggle WARC storage
Let me know if that looks good...thanks!
Perfect, I think these are great. Thanks!
This pull request was deployed and Sentry observed the following issues:
perma.celery_tasks.run_next_capture
View IssueDid you find this useful? React with a 👍 or 👎
This enables WACZ retrieval when the new
DEFAULT_TO_WACZ
setting is enabled. Highlights:DEFAULT_TO_WACZ
feature flag to settings (currently I've left it as false)wacz_size
field toLink
modelDEFAULT_TO_WACZ = True
, the Celery tasksave_scoop_capture
will retrieve a WACZ file alongside the WARC