Closed tinykite closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.02%. Comparing base (
a8a09c3
) to head (e56d572
). Report is 22 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tinykite Just making sure I am following the requirements correctly. The toggle upload dialog button is just a way for us to render the new form without making changes to the current form, right? And once the new form is good, we will basically replace the old form with it (of course remove the toggle itself too). Apologies in advance if I am way too mistaken, we can catch up tomorrow to clarify :)
@tinykite Just making sure I am following the requirements correctly. The toggle upload dialog button is just a way for us to render the new form without making changes to the current form, right? And once the new form is good, we will basically replace the old form with it (of course remove the toggle itself too). Apologies in advance if I am way too mistaken, we can catch up tomorrow to clarify :)
Yes, you are exactly right! Making sure the UI functions as expected before hooking it up to the broader capture process.
What this does
Adds a upload form component to allow users to upload their own static archive if a capture process fails.
Requirements
Render an upload form within a dialog using the existing Dialog wrapper component, as much of the existing HTML as possible, and while refactoring the existing legacy JavaScript.
The dialog should be triggered with a button:![image](https://github.com/harvard-lil/perma/assets/4039311/c69a8af5-87b5-482b-8f28-4bc10caa46f2)
The length of the form — how many inputs it includes — should conditionally depend on if there is a guid from the most recent, failed capture.
A user should be able to fill out the form and click "Upload", but nothing needs to happen after they click the button
How to test
developer-playground
feature flag.https://perma.test:8000/manage/create?dwft_FLAG-NAME=1
UploadForm
component, for example:Additional Notes