harvard-lil / perma

Indelible links
411 stars 70 forks source link

Add upload form #3557

Closed tinykite closed 1 week ago

tinykite commented 2 weeks ago

What this does

Adds a upload form component to allow users to upload their own static archive if a capture process fails.

Requirements

How to test

image

Additional Notes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.02%. Comparing base (a8a09c3) to head (e56d572). Report is 22 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3557 +/- ## =========================================== + Coverage 68.94% 69.02% +0.08% =========================================== Files 48 48 Lines 6900 6918 +18 =========================================== + Hits 4757 4775 +18 Misses 2143 2143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

teovin commented 1 week ago

@tinykite Just making sure I am following the requirements correctly. The toggle upload dialog button is just a way for us to render the new form without making changes to the current form, right? And once the new form is good, we will basically replace the old form with it (of course remove the toggle itself too). Apologies in advance if I am way too mistaken, we can catch up tomorrow to clarify :)

tinykite commented 1 week ago

@tinykite Just making sure I am following the requirements correctly. The toggle upload dialog button is just a way for us to render the new form without making changes to the current form, right? And once the new form is good, we will basically replace the old form with it (of course remove the toggle itself too). Apologies in advance if I am way too mistaken, we can catch up tomorrow to clarify :)

Yes, you are exactly right! Making sure the UI functions as expected before hooking it up to the broader capture process.