Closed tinykite closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.94%. Comparing base (
a8a09c3
) to head (0d7d9a5
). Report is 16 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What this does
While working on an unrelated feature for Perma, I noticed that the behavior of the custom select, that allows users to choose a destination for their next Perma capture, had a bug.
Users could select any option just fine using a mouse, but attempting to navigate past the first option in the list of select options using the down arrow threw a console error. This likely happened when the custom select was slightly refactored — and folders began being passed to the component as a prop rather than being managed internally as a reactive ref.
Reference Screenshot
How to test
Additional notes
After fixing this, I double-checked that other keyboard behaviors still worked as expected as well:
Hitting escape should close the options menu
Hitting home or end should navigate to the first and last options, respectively
Clicking outside the select additional works as expected as well.
While using the arrow keys, the options should not cycle from the last item to the first item (or vice versa), per typical select behavior.
Tab should also not cycle to the next option.