Closed jcushman closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.73%. Comparing base (
161782c
) to head (f3d5fd4
). Report is 7 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some improvements to error handling when capturing URLs, both single link and batch.
Single link errors are shown closer to the form, smaller, read by screen readers, and tweaked handling for a couple of messages:
I also looked at error handling for the batch capture modal and found that its error handling was pretty clunky -- if you don't put in urls, it closes the modal and shows a toast, instead of showing an inline error to let you fix the problem. Pulling this thread, I ended up:
Accessibility notes:
This is forward progress on accessibility, as the single-link errors now get read by VoiceOver. Neither the toasts or inline form errors are being read by VoiceOver for me, however. I think we should address that as a separate bug.