codecov[bot]
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.73%. Comparing base (
66768d3) to head (cfda8c3). Report is 14 commits behind head on develop.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #3624 +/- ## ======================================== Coverage 69.73% 69.73% ======================================== Files 54 54 Lines 7326 7326 ======================================== Hits 5109 5109 Misses 2217 2217 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR follows up on all the work Jack did during the housekeeping cycle to move the Vue JS dashboard project forward. Specifically:
During QA, we noticed a few styling thing that needed tweaking.
Create Link Spacing
The spacing between the organization selection dropdown and "create multiple links" was missing.
Before:
After:
Batch Link Modal Spacing
The spacing between the "Folder" label and the dropdown in the link batch modal was missing.
Before:
After:
No Folder Selected
A small error in logic was preventing the "Please choose a folder" label to appear in the organization selection dropdown, if no folder was selected.
Before:
After:
Mobile Got Messed Up
Before:
After:
Link List Toggle Behavior
When keyboard users click the button to expand a link's detail tray, the keyboard focus is handled by javascript, to ensure that focus stays on the button.
When mouse users click the button (or the row) to expand the details, keyboard focus was set into the first input element of the details tray: the "title" field. As a result, if the title were long, the full title was not visible, because the input field's cursor was at the end.
We decided it was more natural not to do any focus handling when mouse users click.
Link Batch Modal Height
Before Vue, the link batch modal was tall. At some point during the migration to Vue, those styles were lost. Here, they are restored.
Before:
After:
