search

harvard-lil / perma

Indelible links
424 stars 71 forks source link

Personal links dropdown #3626

Closed rebeccacremona closed 1 month ago

rebeccacremona commented 1 month ago

See LIL-2769.

In the recent Great Dashboard Refactoring, the dropdown that org users, registrar users, sponsored users, and admin users can use to select a folder was switched to use a JSON-serialized representation of a folder stored in data-folder instead of an id (or list of ids) stored in data-folderid.

In that refactoring, users' Personal Links folder was left out.

This PR cleans that up, so that it works again 🙂.

It also does a small bit of refactoring: const folders was, before, not a list of folders, but rather, a combined list of orgs and folders, which confused me a lot.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.73%. Comparing base (cfda8c3) to head (d955941). Report is 6 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3626 +/- ## ======================================== Coverage 69.73% 69.73% ======================================== Files 54 54 Lines 7326 7326 ======================================== Hits 5109 5109 Misses 2217 2217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.