Closed rebeccacremona closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.73%. Comparing base (
d955941
) to head (c426eb4
). Report is 4 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
See LIL-2767.
Lots of work has been underway to convert the dashboard to Vue. While doing lots of QA for that work, I noticed that, if a capture failed, it was no longer styled as a failed capture in the link list. While I initially suspected something had gone amiss during the port, I think that actually, this has been broken since we switched from making captures with Perma's own, legacy capture system to making captures with Scoop. When using the legacy capture system, we created placeholder
Capture(role='screenshot'...)
objects for Perma Links by default, and marked them asstatus='failed'
if we didn't get one. Now, we only createCapture
objects for screenshots if we actually have one. And... the code for deciding whether to show theCapture Failed
styles assumed aCapture(role='screenshot'...)
would be present.This PR tweaks the logic to handle the status quo.
Before:
After: