search

harvard-lil / perma

Indelible links
424 stars 71 forks source link

Don't post a message when a link is deleted. #3629

Closed rebeccacremona closed 1 month ago

rebeccacremona commented 1 month ago

See LIL-2768.

You are allowed to (soft) delete a Perma Link for 24hrs after its creation. When you do, we return you to the dashboard. We used to use Django's message framework to post a little notification, communicating that your link had been successfully deleted. But, now that this page is rendered by Vue, that message isn't getting displayed. Instead, Django holds on to the message and displays it... whenever it next gets a chance to display a message. For instance, on the login page 😂 .

We could change things so that you get a javascript-mediated message... but I honestly don't think it's necessary.

This PR just removes the code for posting a message.

rebeccacremona commented 1 month ago

I am looking forward to seeing if this breaks a test. I hope it does :-)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.70%. Comparing base (d955941) to head (2e7354b). Report is 9 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3629 +/- ## =========================================== - Coverage 69.73% 69.70% -0.04% =========================================== Files 54 54 Lines 7326 7317 -9 =========================================== - Hits 5109 5100 -9 Misses 2217 2217 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.