harvard-lts / kakadu-vips

Kakadu JP2 reader and writer for libvips
Apache License 2.0
3 stars 0 forks source link

16-bit image corruption #13

Closed scossu closed 5 months ago

scossu commented 5 months ago

I received some sample images for testing. Among these are 8-bit- and 16-bit-per-channel images, some RGB, some gray.

All 8-bit images convert to JPH without problems; the 16-bit images are corrupted: they look like cut-ups where 128-pixel tall strips are rendered, every other strip missing. The bottom half of the image is black.

I'll follow up with a location of the samples and the jph outcomes.

These images were obtained with vips-8.15 and the latest version of kakadu-vips, using the command line: vips kakaduload src.jp2 dest.jph.

@jcupitt Can you verify how the images convert on your system?

jcupitt commented 5 months ago

Hello, I agree, I see a bad conversion here. I'll dig into it.

jcupitt commented 5 months ago

I fixed a couple of issues and git main kakaduload seems to work well with 16-bit images now.

kakadusave still seems to have some problems, I'll poke it a bit more.

jcupitt commented 5 months ago

I meant to ask, what's the licence on the sample images you sent? Could I use one of them for the kakadu-vips test suite?

jcupitt commented 5 months ago

... git main kakadusave seems to work for 16 bit images too now.

scossu commented 5 months ago

I meant to ask, what's the licence on the sample images you sent? Could I use one of them for the kakadu-vips test suite?

Let me ask our Imaging department. I'll get back to you separately.

scossu commented 5 months ago

The samples are now working. Thanks.

Closing.