search

harvard-ufds / saeczi

Small Area Estimation for Continuous Zero Inflated data
https://harvard-ufds.github.io/saeczi/
Other
4 stars 2 forks source link

adding option for totals #22

Closed joshyam-k closed 8 months ago

joshyam-k commented 8 months ago

Addresses issue #20

joshyam-k commented 8 months ago

@graysonwhite this seems to work, but let me know if anything looks amiss or if you want to rename the parameter

graysonwhite commented 8 months ago

This looks good to me. I think changing the parameter name from res_type to estimand would be a good change, but other than that I think this is good to go!

codecov-commenter commented 8 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (69c3c46) 74.67% compared to head (44a7c71) 73.85%.

:exclamation: Current head 44a7c71 differs from pull request most recent head 1ddf40b. Consider uploading reports for the commit 1ddf40b to get more accurate results

Files Patch % Lines
R/saeczi.R 62.50% 6 Missing :warning:
src/helpers.cpp 85.71% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #22 +/- ## ========================================== - Coverage 74.67% 73.85% -0.82% ========================================== Files 3 3 Lines 379 394 +15 ========================================== + Hits 283 291 +8 - Misses 96 103 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.