search

harvard / cloudJHub

An implementation of JupyterHub within the Amazon cloud, with automatic scaling up and down
BSD 3-Clause "New" or "Revised" License
125 stars 14 forks source link

Ability to specify different Worker username #5

Closed rubysown closed 6 years ago

rubysown commented 6 years ago

We have a CentOS box that is preconfigured with our extensions for JupyterLab. This patch adds the ability to specify a different Worker username versus the Manager's username. I also included a quick conditional statement to silence the worker AMI creation line if it wasn't actually creating one, which confused me at first.

farassadek commented 6 years ago

rubyson

1) Ability to specify different username on the workers.
This seem to be OK

2) For suppress worker AMI creation message if --custom_worker_ami is found in the launch parameters. You need to pass the "config" variable to the "setup_manager" function (line 110 and 120)

farassadek commented 6 years ago

I took care of the config part

rubysown commented 6 years ago

https://github.com/rubysown/cloudJHub/commit/76d297f11de10858cfd1cc9778ae47abb68e7797

I apologize, we also need to add the Worker_Username to the server_params for launch.py.