harvardinformatics / snpArcher

Snakemake workflow for highly parallel variant calling designed for ease-of-use in non-model organisms.
MIT License
63 stars 30 forks source link

Python 3.12 seems to break get_reads() #132

Closed tsackton closed 7 months ago

tsackton commented 8 months ago

The get_reads() function in common.smk results in spaces being inserted into fastq files in Python 3.12:

File path ' results/data/fastq/ GCF_001447265.1 / SAMN04029017 / SRR2240703 _1.fastq.gz ' starts with whitespace. This is likely unintended. It can also lead to inconsistent results of the file-matching approach used by Snakemake.

This probably has to do with changes to how f-strings are parsed in Python 3.12 (see here), but it is not obvious to me exactly how things are going wrong.