Bugfix - Githubissues

harvardinformatics / snpArcher

Snakemake workflow for highly parallel variant calling designed for ease-of-use in non-model organisms.

MIT License

63 stars 30 forks source link

Bugfix #31

Closed sjswuitchik closed 2 years ago

sjswuitchik commented 2 years ago

Fixed java options for picard mark duplicates, as some of the larger data sets were getting java heap space oom errors
reset interval lengths in config.yaml to fix earlier push of Nettapus intervals
added config/ to .gitignore so that issues like changing the sample sheet and interval lengths in config.yaml are not accidentally pushed again

tsackton commented 2 years ago

I don't love having config in .gitignore as it will cause unintentional headaches if/when we actually need to update config options. I think it is better to remember to just not commit local changes to config files. If you use git add instead of git add * it will help to avoid this kind of thing.

Can you delete that change, and then I'll merge this?

sjswuitchik commented 2 years ago

Understandable - fixed! config/ is no longer in .gitignore