search

harvardnlp / encoder-agnostic-adaptation

Encoder-Agnostic Adaptation for Conditional Language Generation
https://arxiv.org/abs/1908.06938
MIT License
79 stars 13 forks source link

Fix the gold index issue in fetching logprob #11

Open fangleai opened 4 years ago

fangleai commented 4 years ago

In story generation task, the original code fetches incorrect index of "logprob", leading to incorrect perplexity evaluation.

Originally: tgt_in = tgt[:-1] log_probs, attn = ... ... gold = tgt_in

Edited: tgt_in = tgt[:-1] log_probs, attn = ... ... gold = tgt[1:]