harvardnlp / namedtensor

Named Tensor implementation for Torch
http://nlp.seas.harvard.edu/NamedTensor
MIT License
441 stars 42 forks source link

README documentation incorrect line 169 logit_dim #98

Open tynanseltzer opened 5 years ago

tynanseltzer commented 5 years ago

On line 169 of README, dist = ntorch.distributions.Categorical(logits=params, logit_dim="logits") is incorrect, in that the keyword is dim_logitas seen on line 27 of namedtensor/distributions/distributions.py. While a simple fix would be changing the README, I actually prefer logit_dim over dim_logit so would prefer changing the keyword. This, however, has issues with backwards compatibility.