Value expectation and 1st order CKY

harvardnlp / pytorch-struct

Fast, general, and tested differentiable structured prediction in PyTorch

http://harvardnlp.github.io/pytorch-struct

MIT License

1.11k stars 93 forks source link

Value expectation and 1st order CKY #93

Open teffland opened 3 years ago

teffland commented 3 years ago

Changes are:

Add 1st order cky implementation with suggested updates
Add value-expectation semiring and test
Make marginal computation work on potentials w/o gradients
Minor clarity/consistency changes to semirings
Some documentation for _Struct

srush commented 3 years ago

Hmm, for some reason the tests are not running on this. Trying to figure out why.

srush commented 3 years ago

Thanks the PR. Lots of nice stuff in here.

teffland commented 3 years ago

Quick dev question: when I try running python setup.py test or python setup.py style, I get error: invalid command 'tests' and error: option --ignore not recognized, respectively. I can run the command on their own, but I'm just wondering if I'm doing something wrong?

srush commented 3 years ago

Interesting, yeah not sure how to run those automatically, I will look into it.