harvest-finance / harvest-front

Front-end for Harvest
Other
0 stars 8 forks source link

Fixes issue with deposit/withdraw/stake buttons looking disabled #11

Closed jumpanda closed 2 years ago

jumpanda commented 2 years ago

I've done the requested changes for secondary -> primary

the default font weight should be 800

Need some clarification for this. Do you mean I should set it as default(currently 500) for the Button component, or use size="lg" for these buttons which includes this font weight?

hubert895 commented 2 years ago

I've done the requested changes for secondary -> primary

the default font weight should be 800

Need some clarification for this. Do you mean I should set it as default(currently 500) for the Button component, or use size="lg" for these buttons which includes this font weight?

The button would be too large if we use the size "lg". We can just use the font weight 800 as default

jumpanda commented 2 years ago
image

I might have misunderstood what you meant, but setting the font weight as default doesn't suit the filter-buttons well

hubert895 commented 2 years ago
image

I might have misunderstood what you meant, but setting the font weight as default doesn't suit the filter-buttons well

This is correct on small monitors.

jumpanda commented 2 years ago

This is correct on small monitors.

Alright 👍 Updated.

hubert895 commented 2 years ago
Screenshot 2022-03-24 at 00 16 10

these buttons can keep the previous font weight

jumpanda commented 2 years ago

Suggestions added.

hubert895 commented 2 years ago

I think we need to do the same change with the claim and buy farm button. Otherwise good to go

s s
hubert895 commented 2 years ago

The font weight of "Buy farm" and "claim" button is incorrect. Both should be 800.

jumpanda commented 2 years ago

The font weight of "Buy farm" and "claim" button is incorrect. Both should be 800.

Done, looks a lot better now!