[BUG] CD-ROM device should not need size

[poldiderjungdrache]

Describe the bug

There is a bit of wired UI behaviour with CD-ROM devices for VMs. When creating a VM and adding a device of type CD-ROM, size remains as mandatory field although the ISO image should define the size:

To Reproduce Steps to reproduce the behavior:

1. Create VM
2. fill basic data
3. Go to Volumes tab
4. Select type CD-ROM and select ISO image, size field remains active and is mandatory

Expected behavior

When selecting type CD-ROM size should be not required as it is denied by the image assigned.

Support bundle

supportbundle_17ecbbe0-3abd-43f0-9267-4cbb33e6282d_2022-04-25T07-22-57Z.zip

Environment:

• Harvester ISO version: 1.0.1
• Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): bare metal (HP ProDesk 400 G6)

Additional context Add any other context about the problem here.

[poldiderjungdrache]

Funny thing is if you under provision the CD-ROM (like lets say set it to 1GB although the ISO is larger than 1GB). The VM does not boot off the install ISO and dumbs me in the EFI Shell:

[w13915984028]

@FrankYang0529 your idea? thanks.

[simonflood]

I bumped into this one today in that I tried booting a VM from a newly uploaded ISO and my first thought it was a corrupt download. After comparing the MD5 checksum of the original file (itself checked against source) with corresponding backing image in Harvester I knew the upload was sound.

The ISO is 11,231,297,536 bytes in size which Harvester lists as 10 GB but it's slightly over which caused the boot to trip. Stopping the VM and increasing the size of the CD-ROM device(!) to 11G allowed the VM to boot from the ISO.

Here's some screenshots showing the failed boot and change of CD-ROM device size(!)

Time to remove the CD-ROM device size or at least automatically set it to match the corresponding ISO (although that would cause a problem if you subsequently change the ISO to a different one which is smaller as it seems you can't reduce the size of the CD-ROM device as I found out in my playing).

[tserong]

I'm looking at this as part of https://github.com/harvester/harvester/issues/4905

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• ~[ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted? The HEP PR is at:~

• [x] Where is the reproduce steps/test steps documented? The reproduce steps/test steps are at:

  • upload a couple of ISO images, one <1GiB in size, one >1GiB in size.
  • create a VM, add a volume and select the >1GiB ISO image. Verify that the size field is automatically set to the size of the ISO (or, the next highest whole number of GiB, e.g. a 3.5GiB ISO will result in a 4GiB size)
  • select the <1GIB ISO. Verify that the size field is automatically set to 1GiB

• [x] Is there a workaround for the issue? If so, where is it documented? The workaround is at: manually set the size field.

• [x] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)? The PR is at: https://github.com/harvester/harvester/pull/5387

  • [x] Does the PR include the explanation for the fix or the feature?

  • ~[ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart? The PR for the YAML change is at: The PR for the chart change is at:~

• [x] If labeled: area/ui Has the UI issue filed or ready to be merged? The UI issue/PR is at: https://github.com/harvester/dashboard/pull/976

• ~[ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?xThe documentation/KB PR is at:~

• [ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• ~[ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility? The compatibility issue is filed at:~

[harvesterhci-io-github-bot]

Automation e2e test issue: harvester/tests#1289