Closed w13915984028 closed 3 weeks ago
We will improve the Storage Network's webhook during the vcluster is enabled. Since Vcluster may contain the running cluster, it's unsuitable to have an automatic mechanism to disable and enable the cluster. However, we can have a document update about the correct process for setting the Storage Network as Vcluster is running.
For the webhook, we can identify the vcluster pvc naming by the vcluster charts:
[ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted? The HEP PR is at:
[x] Where is the reproduce steps/test steps documented? The reproduce steps/test steps are at: https://github.com/harvester/harvester/pull/6576#issue-2532504239
[ ] Is there a workaround for the issue? If so, where is it documented? The workaround is at:
[x] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*
)?
The PR is at: https://github.com/harvester/harvester/pull/6576
[ ] Does the PR include the explanation for the fix or the feature?
[ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart? The PR for the YAML change is at: The PR for the chart change is at:
[ ] If labeled: area/ui Has the UI issue filed or ready to be merged? The UI issue/PR is at:
[ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged? The documentation/KB PR is at:
[ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
[ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility
?
The compatibility issue is filed at:
Automation e2e test issue: harvester/tests#1536
@WebberHuang1118 thanks for this enhancement :smile: :+1: This looks good on v1.4.0-rc3 :smile: I'll go ahead and close this out
@WebberHuang1118 thanks for this enhancement 😄 👍 This looks good on v1.4.0-rc3 😄 I'll go ahead and close this out
Thanks @irishgordo
Is your enhancement related to a problem? Please describe.
Rancher-vcluster
addon is backed with PV by default from Harvester v1.2.0It needs to be added to the storage-network related processing. https://github.com/harvester/harvester/blob/master/pkg/controller/master/storagenetwork/storage_network.go#L730
Describe the solution you'd like
Add source code in Harvester v1.2.1
Describe alternatives you've considered
Add a workaround to Harvester doc in Harvester v1.2.0: suggest user to disable
rancher-vcluster
addon before stoarge-network setting will be changed, and enable the addon again after it.Additional context
Observed in https://github.com/harvester/harvester/pull/4383