harvester / harvester

Open source hyperconverged infrastructure (HCI) software
https://harvesterhci.io/
Apache License 2.0
3.87k stars 327 forks source link

[ENHANCEMENT] Add rancher-vcluster to storage-network setting processing #4397

Closed w13915984028 closed 3 weeks ago

w13915984028 commented 1 year ago

Is your enhancement related to a problem? Please describe.

Rancher-vcluster addon is backed with PV by default from Harvester v1.2.0

It needs to be added to the storage-network related processing. https://github.com/harvester/harvester/blob/master/pkg/controller/master/storagenetwork/storage_network.go#L730

Describe the solution you'd like

Add source code in Harvester v1.2.1

Describe alternatives you've considered

Add a workaround to Harvester doc in Harvester v1.2.0: suggest user to disable rancher-vcluster addon before stoarge-network setting will be changed, and enable the addon again after it.

Additional context

Observed in https://github.com/harvester/harvester/pull/4383

WebberHuang1118 commented 2 months ago

We will improve the Storage Network's webhook during the vcluster is enabled. Since Vcluster may contain the running cluster, it's unsuitable to have an automatic mechanism to disable and enable the cluster. However, we can have a document update about the correct process for setting the Storage Network as Vcluster is running.

WebberHuang1118 commented 2 months ago

For the webhook, we can identify the vcluster pvc naming by the vcluster charts:

harvesterhci-io-github-bot commented 1 month ago

Pre Ready-For-Testing Checklist

harvesterhci-io-github-bot commented 1 month ago

Automation e2e test issue: harvester/tests#1536

irishgordo commented 3 weeks ago

@WebberHuang1118 thanks for this enhancement :smile: :+1: This looks good on v1.4.0-rc3 :smile: I'll go ahead and close this out Screenshot from 2024-10-21 16-19-25

WebberHuang1118 commented 3 weeks ago

@WebberHuang1118 thanks for this enhancement 😄 👍 This looks good on v1.4.0-rc3 😄 I'll go ahead and close this out Screenshot from 2024-10-21 16-19-25

Thanks @irishgordo