[backport v1.3] [BUG] VirtualMachineImageSourceType is an enum but implemented as string

[harvesterhci-io-github-bot]

backport the issue #5510

[harvesterhci-io-github-bot]

Pre Ready-For-Testing Checklist

• [x] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted? The HEP PR is at:

No HEP required as it's a backport.

• [x] Where is the reproduce steps/test steps documented? The reproduce steps/test steps are at:

https://github.com/harvester/harvester/issues/5510 No behavior change is expected. This bug solely relates to Golang typing information used during the generation of the API's swagger.json specification.

• [x] Is there a workaround for the issue? If so, where is it documented? The workaround is at: No workaround necessary.

• [x] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)? The PR is at: https://github.com/harvester/harvester/pull/5511

  • [x] Does the PR include the explanation for the fix or the feature? Yes

  • [x] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart? The PR for the YAML change is at: No YAML change The PR for the chart change is at: No chart change

• [x] If labeled: area/ui Has the UI issue filed or ready to be merged? The UI issue/PR is at: No UI change

• [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged? The documentation/KB PR is at:

Documentation update TBD

• [ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

  • The automation skeleton PR is at:
  • The automation test case PR is at:

• [x] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility? The compatibility issue is filed at: This change is fully backward compatible for any use of Harvester within the design assumptions.

[irishgordo]

@m-ildefons this looks good on v1.3.1-rc1 :smile: :+1: I'll go ahead and close this out :smile:

I've opened up: https://github.com/harvester/harvester/issues/5887

To track the issue of the UI not bubbling up the Error to the User in the Harvester-Dashboard/GUI

[m-ildefons]

:+1: Thanks for checking this out. I've left this issue deliberately open since the docs still need to be updated when v1.3.1 is out, now that the swagger.json for v1.3 has changed, but that's ok. I wasn't even aware that the UI wasn't propagating the error properly.