Open starbops opened 5 months ago
[ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted? The HEP PR is at:
[ ] Where is the reproduce steps/test steps documented? The reproduce steps/test steps are at:
[ ] Is there a workaround for the issue? If so, where is it documented? The workaround is at:
[ ] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*
)?
The PR is at:
[ ] Does the PR include the explanation for the fix or the feature?
[ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart? The PR for the YAML change is at: The PR for the chart change is at:
[ ] If labeled: area/ui Has the UI issue filed or ready to be merged? The UI issue/PR is at:
[ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged? The documentation/KB PR is at:
[ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
[ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility
?
The compatibility issue is filed at:
Automation e2e test issue: harvester/tests#1286
@starbops Could we add a script in the build to check the matching of addons and the packed charts, this may happen from time to time. Thanks.
AFAIK, there are no release branches for add-ons, so it's hard to keep track of which add-on versions go with which versions of Harvester now. Do you have any suggestions?
It seems #4937 is a good place for the discussion.
@starbops I added https://github.com/harvester/harvester-installer/pull/750 to check the version matching between addon and repo.
milestone/release required.
Describe the bug
When upgrading Harvester clusters from v1.2.1 to v1.2.2, the
harvester-seeder
Addon is not upgraded. This could be observed by checking theharvester-seeder
Addon manifest:The image tag was updated as per #5609, but the chart version wasn't. The
0.1.0
chart ofharvester-seeder
is no longer packaged into therancher/harvester-cluster-repo:v1.2.2
image, it's0.1.1
instead:If users have the
harvester-seeder
Addon enabled, during the Harvester upgrade, they'll see a Helm Pod trying to upgrade theharvester-seeder
chart but failing with a chart-not-found error:It's worth noting that this does not jeopardize the entire Harvester upgrade. In my case, the upgrade still ended with success; it's just that the
harvester-seeder
add-on failed to upgrade.To Reproduce Steps to reproduce the behavior:
harvester-seeder
Addonharvester-seeder
Pod, it's still with image tag v0.1.0harvester-seeder
chartExpected behavior
The
harvester-seeder
Addon should be upgraded successfully.Support bundle
Harvester Support Bundle May 21 2024.zip hvst-upgrade-84rsg-upgradelog-archive-2024-05-21T03-33-55Z.zip
Environment
Additional context Add any other context about the problem here.
This incident was first found in #5828, but it's not the root cause of that issue.
The workaround is to manually update the
harvester-seeder
Addon manifest (if it's already enabled, please disable it before patching):