Open w13915984028 opened 1 week ago
[ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted? The HEP PR is at:
[ ] Where is the reproduce steps/test steps documented? The reproduce steps/test steps are at:
[ ] Is there a workaround for the issue? If so, where is it documented? The workaround is at:
[x] Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*
)?
The PR is at: https://github.com/harvester/harvester/pull/6488
[x] Does the PR include the explanation for the fix or the feature?
[ ] Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart? The PR for the YAML change is at: The PR for the chart change is at:
[ ] If labeled: area/ui Has the UI issue filed or ready to be merged? The UI issue/PR is at:
[ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged? The documentation/KB PR is at:
[ ] If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
[ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility
?
The compatibility issue is filed at:
Automation e2e test issue: harvester/tests#1500
Is your enhancement related to a problem? Please describe.
Harvester deployment has following upgrade strategy
https://github.com/harvester/harvester/blob/d794ee0894eec1ff99c8d593cb619ec550a4c3a6/deploy/charts/harvester/values.yaml#L144
But
harvester-webhook
is not set as same.It inherits the default one from k8s
The may lead to some issues on <3 node clusters like https://github.com/harvester/harvester/issues/6432
Another example:
On a single-node harvester cluster, edit the
harvester-webhook
deployment with a new image tag, the harvester-webhook POD will not be replaced at once, instead, you need to delete the current running POD manually to help the replaced POD to be running. After this patch, the POD will be replaced right now.Describe the solution you'd like
Use same deployment upgrade strategy.
Describe alternatives you've considered
Additional context