harvester / harvester

Open source hyperconverged infrastructure (HCI) software
https://harvesterhci.io/
Apache License 2.0
3.77k stars 316 forks source link

[GUI] [ENHANCEMENT] Host local storage support #6685

Open torchiaf opened 2 days ago

torchiaf commented 2 days ago

Is your enhancement related to a problem? Please describe.

Related PR https://github.com/harvester/dashboard/pull/1076

We added LVM and Longhorn V2 storage support in Harvester v1.4. We want to add some restrictions to Volumes, Snapshots and Images functionalities when handling these types of storage and improve error handling.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

torchiaf commented 1 day ago

@a110605 I think keeping the removed disks is something we want by design, there is a dedicate logic to do that:

https://github.com/harvester/dashboard/blob/ed19b0de38713d7f8e363de0cc14006f7c4c218d/edit/host/index.vue#L214-L219

addDisk(id) {
  const removedDisk = findBy(this.removedDisks, 'blockDevice.id', id);

  if (removedDisk) {
    return this.newDisks.push(removedDisk);
  }

I'm not sure if we want to remove this behavior. @bk201 what do you think ?

harvesterhci-io-github-bot commented 1 day ago

Pre Ready-For-Testing Checklist

harvesterhci-io-github-bot commented 1 day ago

Automation e2e test issue: harvester/tests#1565

a110605 commented 11 hours ago

harvester/dashboard#1076

That behavior is strange from my perspective. Is there any harm to clean up the previous remove disk ? cc @bk201

@Vicente-Cheng said backend have no limitation to update disk CR.

tserong commented 10 hours ago

I think we need to disable encryption for LHv2 volumes as well (this is on the LH roadmap for v1.8 -- https://github.com/longhorn/longhorn/wiki/Roadmap#longhorn-v18-january-2025)

tserong commented 9 hours ago

...and just to confirm, LHv2 does support snapshots. I can successfully snapshot and restore volumes using the LH GUI, so the backend functionality works fine. It's behaving weirdly on the Harvester side - I can create snapshots, but when restoring, the new volumes get stuck somehow, but that means we have a separate issue to fix; I don't think that means we should disable snapshots for V2 volumes.

I'll open a separate issue for the snapshot restore weirdness once I've got some more details...