search

harvesthq / platform

A whole new way to add time tracking to your web application.
https://www.getharvest.com/platform
58 stars 11 forks source link

Widget focus problem #45

Open if-kenn opened 6 years ago

if-kenn commented 6 years ago

It looks like you closed #44 suggesting that it had to do with it being a 3rd party extension, it also looks like you don't seem to be responding to comments on closed issues, I am making a new post here.

From the @andyg5000 who initially opened the issue:

The Harvest widget will periodically shift the focus in the browser to the "Stop timer" button automatically on the page. When you're typing a comment and it shifts the focus, it caused the timer to be stopped.

@adunkman I don't think you understand what @andyg5000 is saying, this is not support for a 3rd party extension, this is a problem with the fact that your iframe widget steals the focus after an amount of time so that it actually interrupts a users workflow. It happens exactly when the timer shows that 1 minute has past.

I have made a very minimal HTML/iframe setup and a screen cast in order for you to understand the issue, please note that there is no extension involved with this.

harvest-widget-focus-issue

min-harvest-timer.html.txt (note that I had to make the file .txt in order to upload)

if-kenn commented 6 years ago

@adunkman can you please respond? For something that is suppose to help productivity and the entry of time keeping, this bug is seriously impacting the use for our engineering team. It even seems like it got worse recently as it immediately now takes the focus.

andyg5000 commented 6 years ago

You can also reproduce the issue in Chrome without any custom code:

  1. Load https://platform.harvestapp.com/platform/timer
  2. Start a timer
  3. Remove focus from the "stop timer" button
  4. Wait and watch the "stop timer" button steal focus (~ 1 minute)
braddunbar commented 6 years ago

Hey @if-kenn and @andyg5000! 👋

Sorry about the delay here. I'll take a look at getting that focus-stealing fixed up and get back to you shortly.

braddunbar commented 6 years ago

Hey again! 👋

Looks like you can stop this with the closable=false query parameter. It will remove the cancel button and it won't take focus at all.

I'll always ask around internally about making this the default behavior. It seems like that would be desirable since the cancel button is only useful in a dialog/iframe.

Let me know if that doesn't work out!

if-kenn commented 6 years ago

@braddunbar thanks, it looks like the British version of the word was being used closeable instead of closable!