search

harvesthq / platform

A whole new way to add time tracking to your web application.
https://www.getharvest.com/platform
59 stars 11 forks source link

Const identifier reassignment bug #71

Closed ARahimKhan closed 6 months ago

ARahimKhan commented 6 months ago

We are pulling a platform.js script from the CDN provided in your readme but it stopped working very recently (within last 24 hours). The issue seems to be a const reassignment in the addTimers function. For now, I have resolved this by patching the raw js file and changing const o to let o

I am attaching images for your reference

Console error:

Screenshot 2024-01-12 at 10 02 40 AM

Before patch:

Screenshot 2024-01-12 at 2 10 38 PM

After patch:

Screenshot 2024-01-12 at 2 10 29 PM

Please do let me know if this is expected behaviour or a bug and if it is expected, let me know how I can resolve it without patching the script

pusewicz commented 6 months ago

@ARahimKhan Thank you for raising this issue. We have reverted a recent change that introduced this regression. Can you confirm everything is in order?

ARahimKhan commented 6 months ago

Yes, the issue seems to be fixed now, thanks for the quick resolution