search

harvesthq / platform

A whole new way to add time tracking to your web application.
https://www.getharvest.com/platform
59 stars 11 forks source link

Platform favicon issue (?) #8

Closed alexeds closed 10 years ago

alexeds commented 10 years ago

Two tickets related to favicons not showing up properly when using Platform:

https://iridesco.zendesk.com/agent/#/tickets/92987 https://iridesco.zendesk.com/agent/#/tickets/92840

Are they related or just a coincidence? I've never run into this issue and I'm not sure what could cause it.

@harvesthq/discovery @harvesthq/delta-force

mrsimo commented 10 years ago

I changed some platform favicon stuff last week... if it's ok I'll have a look on monday.

alexeds commented 10 years ago

Totally cool, seems non-urgent. Thanks!

mrsimo commented 10 years ago

Our code for the favicon stuff is quite simple and stupid, if the site doesn't have a favicon the first time an activity is tracked using platform, then we don't store it and it will never more be added.

So the first one is just someone who added a favicon, and the second one I can't find any problem... perhaps they didn't have one either, and added it just now. In any case, they're pending your review @arags. If you think they're OK we can close this!

Cheers!

mrsimo commented 10 years ago

As a side note, if you guys find these keep popping up we can try to work a bit on the favicon stuff and maybe write some cron task that refreshes favicons every few days or something. Refreshing manually is super simple, though.

alexeds commented 10 years ago

Hey @mrsimo those responses look good to me. Go ahead and send and close this!