search

harveysburger / pinnaclewrapper

A C# Wrapper for the PinnacleSports API
25 stars 56 forks source link

fixed up pinnaclewrapper #8

Closed harveysburger closed 5 years ago

harveysburger commented 5 years ago

Hi, the library didn't really work anymore but now it should be ok.

Changing from int to long was the first key change, but also some accounts have been shifted away from api.pinnacle.com to alternate urls. Your library still works fine with those other URLs except the versions for odds and fixtures api aren't the same depending on the domain v3/odds , v1/odds , etc... so I added some optional parameters (defaulted to the value you had before, "v1")

And... while in there I added period status and fixture parentId which are properties added about 1-2 years ago.

I also have a version locally that targets netstandard 2.0 so it can be consumed from netcore 2.2 or netframework 4.7.2 projects, I can push that in as well if you want.

anderj017 commented 5 years ago

Nice work.

FYI I no longer use Pinnacle. Feel free to fork this and make your own library.

harveysburger commented 5 years ago

Cool thanks

Btw feel free to transfer to repo to me if you really don't care for it anymore, or add me as contributor

Or I just evolve my own copy quietly :) up to you

Have a good day,

On Tue, May 21, 2019, 04:55 anderj017, notifications@github.com wrote:

Nice work.

FYI I no longer use Pinnacle. Feel free to fork this and make your own library.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/anderj017/pinnaclewrapper/pull/8?email_source=notifications&email_token=AMDFPYT36TTRBSA5DENFDXDPWO2GJA5CNFSM4HOGDRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV3HKUA#issuecomment-494302544, or mute the thread https://github.com/notifications/unsubscribe-auth/AMDFPYWUNZSBN3PZWOAFBV3PWO2GJANCNFSM4HOGDRFQ .

anderj017 commented 5 years ago

I'll happily transfer it to you. Let me just figure out how to do it...

anderj017 commented 5 years ago

I get an error saying: harveysburger/pinnaclewrapper already exists. Do you have a private repo? Wanna just temporarily rename it so I can transfer it to you?

harveysburger commented 5 years ago

Ok thanks

I renamed my fork https://github.com/harveysburger/pinnaclewrapperfork

Please try again If you still get an error I'll delete my fork

On Wed, May 22, 2019, 05:07 anderj017, notifications@github.com wrote:

I get an error saying: harveysburger/pinnaclewrapper already exists. Do you have a private repo? Wanna just temporarily rename it so I can transfer it to you?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/anderj017/pinnaclewrapper/pull/8?email_source=notifications&email_token=AMDFPYXU5TRYVCCXPPNUDSDPWUEOHA5CNFSM4HOGDRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6NFOA#issuecomment-494719672, or mute the thread https://github.com/notifications/unsubscribe-auth/AMDFPYSCYLBM2WQMOMORJALPWUEOHANCNFSM4HOGDRFQ .

anderj017 commented 5 years ago

Still getting an error: harveysburger already has a repository in the anderj017/pinnaclewrapper network

harveysburger commented 5 years ago

Alright, thanks for your patience

I deleted my fork,

Hopefully will be ok now!

On Wed, May 22, 2019, 18:21 anderj017, notifications@github.com wrote:

Still getting an error: harveysburger already has a repository in the anderj017/pinnaclewrapper network

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/anderj017/pinnaclewrapper/pull/8?email_source=notifications&email_token=AMDFPYUPZMBYJ5VIQY42JOLPWXBNZA5CNFSM4HOGDRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAQTUY#issuecomment-494995923, or mute the thread https://github.com/notifications/unsubscribe-auth/AMDFPYQCQHXOHJW2467DFS3PWXBNZANCNFSM4HOGDRFQ .

anderj017 commented 5 years ago

Looks like it went through: Repository transfer to harveysburger requested

All the best!

harveysburger commented 5 years ago

Great, thanks

On Thu, May 23, 2019, 06:19 anderj017, notifications@github.com wrote:

Looks like it went through: Repository transfer to harveysburger requested

All the best!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/anderj017/pinnaclewrapper/pull/8?email_source=notifications&email_token=AMDFPYQKRAIZOAR55JRVSNTPWZVR7A5CNFSM4HOGDRF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWBYRLQ#issuecomment-495159470, or mute the thread https://github.com/notifications/unsubscribe-auth/AMDFPYUPTVZLUJV7G6CUA6TPWZVR7ANCNFSM4HOGDRFQ .