Suggestion: python config

harvie256 / midi-commander-custom

Custom Firmware for the MeloAudio Midi Commander

MIT License

43 stars 14 forks source link

Suggestion: python config #18

Open ffabreti opened 2 years ago

ffabreti commented 2 years ago

Hi @harvie256 What about integrating the CSV file into the repo so that we can track changes ? I've created a specific dir for configs too.

https://github.com/ffabreti/midi-commander-custom/commit/8ffa8a304cfefe27987b6afce60c7b0eb36cb8e3

ffabreti commented 2 years ago

I think we can define a empty Google Sheet with formatting for better reading and import/export from there. So that we can simply paste the CSV in there, and Download later as CSV.

This is possible if we define the lines that will be fixed like :

Line 35 must be Button_Settings
Line 39 must be Bank_Number
etc

ffabreti commented 2 years ago

Google Sheets conditional formating of colors, vertical text is fixed for line 39 Could no find where to change idiom to english.

harvie256 commented 2 years ago

Looks great, I like the colouring. I haven't really played with locking cells in google sheets, if it works then great!

I am slowly working on a desktop GUI app for the configuration to make it easier for folk that find the whole CSV->Python thing a bit much. Also it will allow to more interesting features to come to life. But that could be a little while off depending on how much free time I actually get to work on it.

Do you want to drop whatever changes into a pull request and we'll incorporate them?

ffabreti commented 2 years ago

Great, will do more testing to confirm the workflow. In what framework are you developing the frontend? Maybe I can help.

harvie256 commented 2 years ago

C# WPF I know it's not multi platform, but it's easy to work with...

ffabreti commented 2 years ago

Didn't know it. Will take a look at it. This guy says not to start dragging things into the form because it ends up with fixed alignments that may become a nightmare.

harvie256 commented 2 years ago

That's right, it's very similar in ways to coding for Android etc where you're doing the layout in responsive containers using xml.

ffabreti commented 2 years ago

Hey @harvie256

I tested the spreadsheet template and decide to go the "Apps Script" route. Not sure if it was worth it, but it helps.

Take a look at this commit and this sheet

User only needs to open google spreadsheet (not this specific sheet, but any empty one), paste the CSV and paste the script.