search

harvimt / quamash

Implementation of the PEP 3156 event-loop (asyncio) api using the Qt Event-Loop
BSD 2-Clause "Simplified" License
265 stars 46 forks source link

Fix issue #34 #40

Closed Insoleet closed 9 years ago

Insoleet commented 9 years ago

Gotcha !

So there were to references to remove : timer and handle in the callback instance. Please check the validity of my code but it should be ok.

harvimt commented 9 years ago

The tests are not passing in CI, though they are passing locally for me (on linux)

Looks like there are some problems with appveyor and broken URLs? I'll fix them in master and then rebase.

harvimt commented 9 years ago

Note that the Circle CI tests don't work, I haven't actually set them up yet...

The Travis builds are failing on both the "use quamash" and "don't use quamash" state, so it's probably something weird. I'd like to see passing tests on windows, but it's hard to see how this could make it worse.

Insoleet commented 9 years ago

I wonder why the tests are passing locally but not on Travis ? May it be related to https://docs.python.org/3.4/library/gc.html#gc.garbage , where before python 3.4, objects with a del method could not be deleted by the garbage collector ?

harvimt commented 9 years ago

Travis is running both Python 3.4 and Python 3.3 tests and both fail... so that's not it.

On Thu, Aug 20, 2015 at 9:41 AM, Insoleet notifications@github.com wrote:

I wonder why the tests are passing locally but not on Travis ? May it be related to https://docs.python.org/3.4/library/gc.html#gc.garbage , where before python 3.4, objects with a del method could not be deleted by the garbage collector ?

— Reply to this email directly or view it on GitHub https://github.com/harvimt/quamash/pull/40#issuecomment-133071452.

Insoleet commented 9 years ago

On python 3.4, it's only flake8 which fails. The test is passing. https://travis-ci.org/harvimt/quamash/jobs/76489498

harvimt commented 9 years ago

Hrm. Using del x instead of x = None didn't work either.

harvimt commented 9 years ago

(In hindsight I don't know why it would have)

Insoleet commented 9 years ago

The problem is that the custom del is never called on the Task for Python 3.3. The Task is deleted but the exception handler is not called.
I'm not sure what should be done. Maybe just disable the test for python < 3.4...

harvimt commented 9 years ago

Alright, I marked the test as xfail on python 3.3, did a little minor rebasing. I'm probably ready to push a bugfix release to PyPI.

Insoleet commented 9 years ago

That'd be perfect :)